db-ai-bridge: Add hostname resolution support for Lakebase Pool#310
Open
db-ai-bridge: Add hostname resolution support for Lakebase Pool#310
Conversation
jennsun
changed the title
3 tasks
bbqiu
reviewed
Feb 2, 2026
| resolved_host = getattr(instance, "read_write_dns", None) or getattr( | ||
| instance, "read_only_dns", None | ||
| ) | ||
| # If input is hostname (e.g., from Databricks Apps valueFrom resolution) |
Collaborator
There was a problem hiding this comment.
does it make sense to have the helper inside of this method?
i think if the method here is accepting a param "instance name", then this might be a helpful standalone helper? something that will resolve to a validated instance name, whether given a hostname or an instance name
bbqiu
reviewed
Feb 2, 2026
| @@ -1056,3 +1056,104 @@ def test_execute_grant_handles_insufficient_privilege(self): | |||
| error_msg = str(exc_info.value) | |||
| assert "Insufficient privileges" in error_msg | |||
| assert "CAN MANAGE" in error_msg | |||
Collaborator
There was a problem hiding this comment.
can we add an integration test where we use real values from dogfood to verify this logic?
bbqiu
reviewed
Feb 2, 2026
bbqiu
reviewed
Feb 2, 2026
bbqiu
reviewed
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow LakebasePool to accept either instance name or hostname. When a hostname is provided (detected by .database. pattern), it resolves to the instance name by listing database instances.
This would support cases like when Databricks Apps resolves to hostname using resource reference (
valueFromin app.yaml)conversation thread from prev PR: #274 (comment)